[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 06/10] hw/s390x/ipl.c: replace deprecated qbus_re
From: |
Damien Hedde |
Subject: |
[Qemu-devel] [PATCH v4 06/10] hw/s390x/ipl.c: replace deprecated qbus_reset_all registration |
Date: |
Wed, 21 Aug 2019 18:33:37 +0200 |
Replace deprecated qbus_reset_all by resettable_cold_reset_fn for
the ipl registration in the main reset handlers.
This does not impact the behavior: qbus_reset_all is already a wrapper
for the cold reset function.
Signed-off-by: Damien Hedde <address@hidden>
---
Cc: Cornelia Huck <address@hidden>
Cc: address@hidden
Cc: Christian Borntraeger <address@hidden>
Cc: Thomas Huth <address@hidden>
---
hw/s390x/ipl.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
index ca544d64c5..2689f7a017 100644
--- a/hw/s390x/ipl.c
+++ b/hw/s390x/ipl.c
@@ -237,7 +237,15 @@ static void s390_ipl_realize(DeviceState *dev, Error
**errp)
*/
ipl->compat_start_addr = ipl->start_addr;
ipl->compat_bios_start_addr = ipl->bios_start_addr;
- qemu_register_reset(qdev_reset_all_fn, dev);
+ /*
+ * Because this Device is not on any bus in the qbus tree (it is
+ * not a sysbus device and it's not on some other bus like a PCI
+ * bus) it will not be automatically reset by the 'reset the
+ * sysbus' hook registered by vl.c like most devices. So we must
+ * manually register a reset hook for it.
+ * TODO: there should be a better way to do this.
+ */
+ qemu_register_reset(resettable_cold_reset_fn, dev);
error:
error_propagate(errp, err);
}
--
2.22.0
- [Qemu-devel] [PATCH v4 00/10] Multi-phase reset mechanism, Damien Hedde, 2019/08/21
- [Qemu-devel] [PATCH v4 03/10] hw/core: add Resettable interface in Bus and Device classes, Damien Hedde, 2019/08/21
- [Qemu-devel] [PATCH v4 02/10] hw/core: create Resettable QOM interface, Damien Hedde, 2019/08/21
- [Qemu-devel] [PATCH v4 04/10] docs/devel/reset.txt: create doc about Resettable interface, Damien Hedde, 2019/08/21
- [Qemu-devel] [PATCH v4 05/10] vl.c: replace deprecated qbus_reset_all registration, Damien Hedde, 2019/08/21
- [Qemu-devel] [PATCH v4 06/10] hw/s390x/ipl.c: replace deprecated qbus_reset_all registration,
Damien Hedde <=
- [Qemu-devel] [PATCH v4 01/10] add device_legacy_reset function to prepare for reset api change, Damien Hedde, 2019/08/21
- [Qemu-devel] [PATCH v4 07/10] hw/core/qdev: replace deprecated device_legacy_reset when hotplugging device, Damien Hedde, 2019/08/21
- [Qemu-devel] [PATCH v4 08/10] hw/core/resettable: add support for warm reset, Damien Hedde, 2019/08/21
- [Qemu-devel] [PATCH v4 09/10] hw/core/: add warm reset helpers for devices and buses, Damien Hedde, 2019/08/21
- [Qemu-devel] [PATCH v4 10/10] docs/devel/reset.txt: add documentation about warm reset, Damien Hedde, 2019/08/21
- Re: [Qemu-devel] [PATCH v4 00/10] Multi-phase reset mechanism, no-reply, 2019/08/21