Re: [Qemu-devel] [PULL 00/36] QEMU patches for 2018-08-20

[Peter Maydell]

On Tue, 20 Aug 2019 at 08:02, Paolo Bonzini <address@hidden> wrote:
>
> The following changes since commit 864ab314f1d924129d06ac7b571f105a2b76a4b2:
>
>   Update version for v4.1.0-rc4 release (2019-08-06 17:05:21 +0100)
>
> are available in the git repository at:
>
>   git://github.com/bonzini/qemu.git tags/for-upstream
>
> for you to fetch changes up to 6f93977075ae9971d73879ca872f75e2737f66c5:
>
>   x86: Intel AVX512_BF16 feature enabling (2019-08-20 08:59:18 +0200)
>
> ----------------------------------------------------------------
> * New KVM PV features (Marcelo, Wanpeng)
> * valgrind fixes (Andrey)
> * Remove clock reset notifiers (David)
> * KConfig and Makefile cleanups (Paolo)
> * Replay and icount improvements (Pavel)
> * x86 FP fixes (Peter M.)
> * TCG locking assertions (Roman)
> * x86 support for mmap-ed -kernel/-initrd (Stefano)
> * Other cleanups (Wei Yang, Yan Zhao, Tony)
> * LSI fix for infinite loop (Prasad)
> * ARM migration fix (Catherine)
> * AVX512_BF16 feature (Jing)
>
> ----------------------------------------------------------------

Hi; this fails to compile (all platforms):

/home/petmay01/linaro/qemu-for-merges/hw/core/loader.c: In function ‘rom_reset’:
/home/petmay01/linaro/qemu-for-merges/hw/core/loader.c:1123:9: error:
implicit declaration of function ‘runstate_check’; did you mean
‘type_check’? [-Werror=implicit-function-declaration]
     if (runstate_check(RUN_STATE_INMIGRATE))
         ^~~~~~~~~~~~~~
         type_check
/home/petmay01/linaro/qemu-for-merges/hw/core/loader.c:1123:9: error:
nested extern declaration of ‘runstate_check’ [-Werror=nested-externs]
cc1: all warnings being treated as errors
/home/petmay01/linaro/qemu-for-merges/rules.mak:69: recipe for target
'hw/core/loader.o' failed

I suspect the patchset has a semantic conflict with Marcus's
include-cleanup and needs an extra #include somewhere.

thanks
-- PMM