[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/5] socket: Add backlog parameter to socket_
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/5] socket: Add backlog parameter to socket_listen |
Date: |
Tue, 20 Aug 2019 11:14:50 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Daniel P. Berrangé <address@hidden> wrote:
> On Tue, Aug 20, 2019 at 10:24:55AM +0200, Juan Quintela wrote:
>> Current parameter was always one. We continue with that value for now
>> in all callers.
>>
>> Signed-off-by: Juan Quintela <address@hidden>
>> @@ -309,7 +311,8 @@ static int inet_listen_saddr(InetSocketAddress *saddr,
>> goto listen_failed;
>> }
>> } else {
>> - if (!listen(slisten, 1)) {
>> + trace_inet_listen_saddr(num);
>
> It is a bit odd to only have the trace event for inet sockets. I'd
> prefer it in the caller for all sockets, with just "socket_listen"
> name.
Ok. will change.
This is the one that I needed, I just changed an error_report() to a
trace O:-)
- [Qemu-devel] [PATCH v2 0/5] Fix multifd with big number of channels, Juan Quintela, 2019/08/20
- [Qemu-devel] [PATCH v2 1/5] socket: Add backlog parameter to socket_listen, Juan Quintela, 2019/08/20
- [Qemu-devel] [PATCH v2 2/5] socket: Add num connections to qio_channel_socket_sync(), Juan Quintela, 2019/08/20
- [Qemu-devel] [PATCH v2 3/5] socket: Add num connections to qio_channel_socket_async(), Juan Quintela, 2019/08/20
- [Qemu-devel] [PATCH v2 4/5] socket: Add num connections to qio_net_listener_open_sync(), Juan Quintela, 2019/08/20
- [Qemu-devel] [PATCH v2 5/5] multifd: Use number of channels as listen backlog, Juan Quintela, 2019/08/20