Re: [Qemu-devel] [PATCH] linux-user: erroneous fd_trans_unregister call

[Laurent Vivier]

Le 19/08/2019 à 20:53, Shu-Chun Weng via Qemu-devel a écrit :
> timer_getoverrun returns the "overrun count" for the timer, which is not
> a file descriptor and thus should not call fd_trans_unregister on it.
> 
> Signed-off-by: Shu-Chun Weng <address@hidden>
> ---
>  linux-user/syscall.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 8367cb138d..012d79f8c1 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -11846,7 +11846,6 @@ static abi_long do_syscall1(void *cpu_env, int num, 
> abi_long arg1,
>              timer_t htimer = g_posix_timers[timerid];
>              ret = get_errno(timer_getoverrun(htimer));
>          }
> -        fd_trans_unregister(ret);
>          return ret;
>      }
>  #endif
> 

Reviewed-by: Laurent Vivier <address@hidden>