[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [EXTERNAL][PATCH v8 36/37] target/mips: tests/tcg: Add
From: |
Aleksandar Rikalo |
Subject: |
Re: [Qemu-devel] [EXTERNAL][PATCH v8 36/37] target/mips: tests/tcg: Add optional printing of more detailed failure info |
Date: |
Mon, 19 Aug 2019 14:49:09 +0000 |
> From: Aleksandar Markovic <address@hidden>
> Sent: Monday, August 19, 2019 2:08 PM
> To: address@hidden <address@hidden>
> Cc: address@hidden <address@hidden>; Aleksandar Markovic <address@hidden>;
> Aleksandar Rikalo <address@hidden>
> Subject: [EXTERNAL][PATCH v8 36/37] target/mips: tests/tcg: Add optional
> printing of more detailed failure info
>
> From: Aleksandar Markovic <address@hidden>
>
> There is a need for printing input and output data for failure cases,
> for debugging purpose. This is achieved by this patch, and only if a
> preprocessor constant is manually set to 1. (Assumption is that the
> need for such printout is relatively rare.)
>
> Signed-off-by: Aleksandar Markovic <address@hidden>
> ---
> tests/tcg/mips/include/test_utils_128.h | 23 ++++++++++++++++++++++-
> 1 file changed, 22 insertions(+), 1 deletion(-)
>
> diff --git a/tests/tcg/mips/include/test_utils_128.h
> b/tests/tcg/mips/include/test_utils_128.h
> index 2fea610..0dd3868 100644
> --- a/tests/tcg/mips/include/test_utils_128.h
> +++ b/tests/tcg/mips/include/test_utils_128.h
> @@ -27,7 +27,8 @@
> #include <inttypes.h>
> #include <string.h>
>
> -#define PRINT_RESULTS 0
> +#define PRINT_RESULTS 0
> +#define PRINT_FAILURES 0
>
>
> static inline int32_t check_results_128(const char *isa_ase_name,
> @@ -65,6 +66,26 @@ static inline int32_t check_results_128(const char
> *isa_ase_name,
> (b128_result[2 * i + 1] == b128_expect[2 * i + 1])) {
> pass_count++;
> } else {
> +#if PRINT_FAILURES
> + uint32_t ii;
> + uint64_t a, b;
> +
> + printf("\n");
> +
> + printf("FAILURE for test case %d!\n", i);
> +
> + memcpy(&a, (b128_expect + 2 * i), 8);
> + memcpy(&b, (b128_expect + 2 * i + 1), 8);
> + printf("Expected result : { 0x%016llxULL, 0x%016llxULL, },\n",
> + a, b);
> +
> + memcpy(&a, (b128_result + 2 * i), 8);
> + memcpy(&b, (b128_result + 2 * i + 1), 8);
> + printf("Actual result : { 0x%016llxULL, 0x%016llxULL, },\n",
> + a, b);
> +
> + printf("\n");
> +#endif
> fail_count++;
> }
> }
> --
> 2.7.4
Reviewed-by: Aleksandar Rikalo <address@hidden>
- [Qemu-devel] [PATCH v8 24/37] target/mips: Clean up handling of CP0 register 10, (continued)
- [Qemu-devel] [PATCH v8 24/37] target/mips: Clean up handling of CP0 register 10, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 26/37] target/mips: Clean up handling of CP0 register 12, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 15/37] target/mips: Style improvements in mips_malta.c, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 31/37] target/mips: Clean up handling of CP0 register 23, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 11/37] target/mips: Style improvements in translate.c, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 33/37] target/mips: Clean up handling of CP0 register 26, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 32/37] target/mips: Clean up handling of CP0 register 24, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 36/37] target/mips: tests/tcg: Add optional printing of more detailed failure info, Aleksandar Markovic, 2019/08/19
- Re: [Qemu-devel] [EXTERNAL][PATCH v8 36/37] target/mips: tests/tcg: Add optional printing of more detailed failure info,
Aleksandar Rikalo <=
- [Qemu-devel] [PATCH v8 34/37] target/mips: Clean up handling of CP0 register 30, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 35/37] target/mips: Clean up handling of CP0 register 31, Aleksandar Markovic, 2019/08/19
- [Qemu-devel] [PATCH v8 37/37] target/mips: tests/tcg: Fix target configurations for MSA tests, Aleksandar Markovic, 2019/08/19