qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [Bug 1840646] Re: qemu-4.1.0/roms/SLOF/lib/libnet/ping.c:12


From: Peter Maydell
Subject: [Qemu-devel] [Bug 1840646] Re: qemu-4.1.0/roms/SLOF/lib/libnet/ping.c:122: logical fault
Date: Mon, 19 Aug 2019 11:58:58 -0000

(Anything in a git submodule will be third-party code that's not part of
QEMU.)

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1840646

Title:
  qemu-4.1.0/roms/SLOF/lib/libnet/ping.c:122: logical fault

Status in QEMU:
  Invalid

Bug description:
  qemu-4.1.0/roms/SLOF/lib/libnet/ping.c:122:16: warning: Logical
  conjunction always evaluates to false: alen <= 0 && alen >=
  sizeof(args) - 1. [incorrectLogicOperator]

  Source code is

     if (alen <= 0 && alen >= sizeof(args) - 1) {

  Maybe better code:

     if (alen <= 0 || alen >= sizeof(args) - 1) {

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1840646/+subscriptions



reply via email to

[Prev in Thread] Current Thread [Next in Thread]