Re: [Qemu-devel] [PATCH v4 14/14] audio: fix memory leak reported by ASAN

[Philippe Mathieu-Daudé]

Hi Zoltán,

On 8/19/19 1:06 AM, Kővágó, Zoltán wrote:
> Signed-off-by: Kővágó, Zoltán <address@hidden>
> ---
>  audio/audio.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/audio/audio.c b/audio/audio.c
> index 924dddf2e7..9b28abca14 100644
> --- a/audio/audio.c
> +++ b/audio/audio.c
> @@ -1343,6 +1343,12 @@ static void free_audio_state(AudioState *s)
>          qapi_free_Audiodev(s->dev);
>          s->dev = NULL;
>      }
> +
> +    if (s->ts) {
> +        timer_free(s->ts);
> +        s->ts = NULL;
> +    }

Why not directly fix audio_cleanup() previous to your series?

> +
>      g_free(s);
>  }
>  
>