[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] target/arm: Allow ARMCPRegInfo read/write f
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] target/arm: Allow ARMCPRegInfo read/write functions to throw exceptions |
Date: |
Sun, 18 Aug 2019 07:12:07 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 8/16/19 1:58 PM, Peter Maydell wrote:
> @@ -1729,6 +1729,12 @@ static void handle_sys(DisasContext *s, uint32_t insn,
> bool isread,
> tcg_temp_free_ptr(tmpptr);
> tcg_temp_free_i32(tcg_syn);
> tcg_temp_free_i32(tcg_isread);
> + } else if (ri->type & ARM_CP_RAISES_EXC) {
> + /*
> + * The readfn or writefn might raise an exception;
> + * synchronize the CPU state in case it does.
> + */
> + gen_a64_set_pc_im(s->pc - 4);
This will now need an update for master, but otherwise,
Reviewed-by: Richard Henderson <address@hidden>
r~