[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] pc: Don't make CPU properties mandatory unl
|
From: |
Erik Skultety |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/3] pc: Don't make CPU properties mandatory unless necessary |
|
Date: |
Fri, 16 Aug 2019 09:49:32 +0200 |
|
User-agent: |
Mutt/1.12.1 (2019-06-15) |
On Fri, Aug 16, 2019 at 08:10:20AM +0200, Markus Armbruster wrote:
> Eduardo Habkost <address@hidden> writes:
>
> > We have this issue reported when using libvirt to hotplug CPUs:
> > https://bugzilla.redhat.com/show_bug.cgi?id=1741451
> >
> > Basically, libvirt is not copying die-id from
> > query-hotpluggable-cpus, but die-id is now mandatory.
>
> Uh-oh, "is now mandatory": making an optional property mandatory is an
> incompatible change. When did we do that? Commit hash, please.
>
> [...]
>
I don't even see it as being optional ever - the property wasn't even
recognized before commit 176d2cda0de introduced it as mandatory.
Regards,
Erik
[Qemu-devel] [PATCH 2/3] pc: Improve error message when die-id is omitted, Eduardo Habkost, 2019/08/15
[Qemu-devel] [PATCH 3/3] pc: Don't make CPU properties mandatory unless necessary, Eduardo Habkost, 2019/08/15
Re: [Qemu-devel] [PATCH 3/3] pc: Don't make CPU properties mandatory unless necessary, Eduardo Habkost, 2019/08/16
Re: [Qemu-devel] [PATCH 3/3] pc: Don't make CPU properties mandatory unless necessary, Igor Mammedov, 2019/08/16