[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 13/33] migration/postcopy: start_postcopy could be tr
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[Qemu-devel] [PULL 13/33] migration/postcopy: start_postcopy could be true only when migrate_postcopy() return true |
Date: |
Thu, 15 Aug 2019 17:34:44 +0100 |
From: Wei Yang <address@hidden>
There is only one place to set start_postcopy to true,
qmp_migrate_start_postcopy(), which make sure start_postcopy could be
set to true when migrate_postcopy() return true.
So start_postcopy is true implies the other one.
Signed-off-by: Wei Yang <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
---
migration/migration.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index 7c66da3a83..8331e62831 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -3103,8 +3103,7 @@ static MigIterateState
migration_iteration_run(MigrationState *s)
if (pending_size && pending_size >= s->threshold_size) {
/* Still a significant amount to transfer */
- if (migrate_postcopy() && !in_postcopy &&
- pend_pre <= s->threshold_size &&
+ if (!in_postcopy && pend_pre <= s->threshold_size &&
atomic_read(&s->start_postcopy)) {
if (postcopy_start(s)) {
error_report("%s: postcopy failed to start", __func__);
--
2.21.0
- [Qemu-devel] [PULL 03/33] migration: consolidate time info into populate_time_info, (continued)
- [Qemu-devel] [PULL 03/33] migration: consolidate time info into populate_time_info, Dr. David Alan Gilbert (git), 2019/08/15
- [Qemu-devel] [PULL 05/33] migration/postcopy: break the loop when there is no more page to discard, Dr. David Alan Gilbert (git), 2019/08/15
- [Qemu-devel] [PULL 04/33] migration/postcopy: the valid condition is one less then end, Dr. David Alan Gilbert (git), 2019/08/15
- [Qemu-devel] [PULL 06/33] migration/postcopy: discard_length must not be 0, Dr. David Alan Gilbert (git), 2019/08/15
- [Qemu-devel] [PULL 07/33] migration/postcopy: reduce one operation to calculate fixup_start_addr, Dr. David Alan Gilbert (git), 2019/08/15
- [Qemu-devel] [PULL 08/33] migration/postcopy: do_fixup is true when host_offset is non-zero, Dr. David Alan Gilbert (git), 2019/08/15
- [Qemu-devel] [PULL 09/33] migration/savevm: flush file for iterable_only case, Dr. David Alan Gilbert (git), 2019/08/15
- [Qemu-devel] [PULL 10/33] migration/savevm: split qemu_savevm_state_complete_precopy() into two parts, Dr. David Alan Gilbert (git), 2019/08/15
- [Qemu-devel] [PULL 11/33] migration/savevm: move non SaveStateEntry condition check out of iteration, Dr. David Alan Gilbert (git), 2019/08/15
- [Qemu-devel] [PULL 12/33] migration/postcopy: PostcopyState is already set in loadvm_postcopy_handle_advise(), Dr. David Alan Gilbert (git), 2019/08/15
- [Qemu-devel] [PULL 13/33] migration/postcopy: start_postcopy could be true only when migrate_postcopy() return true,
Dr. David Alan Gilbert (git) <=
- [Qemu-devel] [PULL 14/33] migration: use migration_in_postcopy() to check POSTCOPY_ACTIVE, Dr. David Alan Gilbert (git), 2019/08/15
- [Qemu-devel] [PULL 15/33] migration: just pass RAMBlock is enough, Dr. David Alan Gilbert (git), 2019/08/15
- [Qemu-devel] [PULL 17/33] migration: return -EINVAL directly when version_id mismatch, Dr. David Alan Gilbert (git), 2019/08/15
- [Qemu-devel] [PULL 16/33] migration: equation is more proper than and to check LOADVM_QUIT, Dr. David Alan Gilbert (git), 2019/08/15
- [Qemu-devel] [PULL 18/33] migration: extract ram_load_precopy, Dr. David Alan Gilbert (git), 2019/08/15
- [Qemu-devel] [PULL 19/33] migration/postcopy: make PostcopyDiscardState a static variable, Dr. David Alan Gilbert (git), 2019/08/15
- [Qemu-devel] [PULL 20/33] migration/postcopy: simplify calculation of run_start and fixup_start_addr, Dr. David Alan Gilbert (git), 2019/08/15
- [Qemu-devel] [PULL 21/33] migration/postcopy: use QEMU_IS_ALIGNED to replace host_offset, Dr. David Alan Gilbert (git), 2019/08/15
- [Qemu-devel] [PULL 22/33] hmp: Remove migration capabilities from "info migrate", Dr. David Alan Gilbert (git), 2019/08/15
- [Qemu-devel] [PULL 23/33] migration: remove unused field bytes_xfer, Dr. David Alan Gilbert (git), 2019/08/15