[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/4] qcow2: async handling of fragmented io
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/4] qcow2: async handling of fragmented io |
Date: |
Thu, 15 Aug 2019 15:39:50 +0000 |
15.08.2019 17:09, Max Reitz wrote:
> On 15.08.19 14:10, Vladimir Sementsov-Ogievskiy wrote:
>> Hi all!
>>
>> Here is an asynchronous scheme for handling fragmented qcow2
>> reads and writes. Both qcow2 read and write functions loops through
>> sequential portions of data. The series aim it to parallelize these
>> loops iterations.
>> It improves performance for fragmented qcow2 images, I've tested it
>> as described below.
>
> Looks good to me, but I can’t take it yet because I need to wait for
> Stefan’s branch to be merged, of course.
>
> Speaking of which, why didn’t you add any tests for the *_part()
> methods? I find it a bit unsettling that nothing would have caught the
> bug you had in v2 in patch 3.
>
Hmm, any test with write to fragmented area should have caught it.. Ok,
I'll think of something.
--
Best regards,
Vladimir
- Re: [Qemu-devel] [PATCH v3 1/4] block: introduce aio task pool, (continued)
- [Qemu-devel] [PATCH v3 3/4] block/qcow2: refactor qcow2_co_pwritev_part, Vladimir Sementsov-Ogievskiy, 2019/08/15
- [Qemu-devel] [PATCH v3 2/4] block/qcow2: refactor qcow2_co_preadv_part, Vladimir Sementsov-Ogievskiy, 2019/08/15
- [Qemu-devel] [PATCH v3 4/4] block/qcow2: introduce parallel subrequest handling in read and write, Vladimir Sementsov-Ogievskiy, 2019/08/15
- Re: [Qemu-devel] [PATCH v3 0/4] qcow2: async handling of fragmented io, Max Reitz, 2019/08/15
- Re: [Qemu-devel] [PATCH v3 0/4] qcow2: async handling of fragmented io, Max Reitz, 2019/08/15
- Re: [Qemu-devel] [PATCH v3 0/4] qcow2: async handling of fragmented io,
Vladimir Sementsov-Ogievskiy <=