[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] qemu-img convert: Deprecate using -n and -o
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v2] qemu-img convert: Deprecate using -n and -o together |
Date: |
Thu, 15 Aug 2019 14:31:21 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 15.08.19 13:06, Kevin Wolf wrote:
> bdrv_create options specified with -o have no effect when skipping image
> creation with -n, so this doesn't make sense. Warn against the misuse
> and deprecate the combination so we can make it a hard error later.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>
> - Hopefully removed the "finger-wagging" that John saw, without stating
> that the combination doesn't have a well-defined behaviour (because
> skipping image creation and therefore ignoring -o is well-defined
> behaviour).
The problem is that e.g. the man page never says that -o gives creation
options. It says that “options is a [...] list of format specific
options”, nothing more.
> qemu-img.c | 5 +++++
> qemu-deprecated.texi | 7 +++++++
> 2 files changed, 12 insertions(+)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature