Re: [Qemu-devel] [PATCH 4/4] configure: Log the libssh version detected

[Pino Toscano]

On Wednesday, 14 August 2019 14:15:27 CEST Philippe Mathieu-Daudé wrote:
> Log wether the version is 0.7 or 0.8 to better understand
> user reports.
> 
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
>  configure | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 040aa8eb6c..d06cee0ba0 100755
> --- a/configure
> +++ b/configure
> @@ -3930,6 +3930,7 @@ if test "$libssh" != "no" ; then
>    if $pkg_config --exists libssh; then
>      libssh_cflags=$($pkg_config libssh --cflags)
>      libssh_libs=$($pkg_config libssh --libs)
> +    libssh_version=$($pkg_config libssh --modversion)
>      libssh=yes
>    else
>      if test "$libssh" = "yes" ; then
> @@ -3960,6 +3961,9 @@ int main(void) { return ssh_get_publickey(NULL, NULL); }
>  EOF
>    if compile_object "$libssh_cflags -DHAVE_LIBSSH_0_8"; then
>      libssh_cflags="-DHAVE_LIBSSH_0_8 $libssh_cflags"
> +  else
> +    # If this is not libssh 0.8, this is likely 0.7
> +    libssh_version="0.7"
>    fi

Not sure why this though -- please leave it out, and just log the
version as found.

-- 
Pino Toscano

signature.asc
Description: This is a digitally signed message part.