Re: [Qemu-devel] [PATCH v3 00/13] softfloat updates (include tweaks, rm LIT64)

[Markus Armbruster]

Alex Bennée <address@hidden> writes:

> Hi,
>
> Another iteration of updates for softfloat. Instead of moving the
> LIT64() macro from one file to another we convert the uses to the
> stdint.h macro. I did eliminate one of the uses by converting the
> squash_input_denormal functions to the new style code. However as you
> can see with the follow-up patch it bloated the code a little. I'd
> like to convert the x80 and 128bit FP functions to the new style but
> the challenge is seeing how we can get greater re-use of the common
> functions without bloating the generated code. However if we can do
> that we should eliminate a class of bugs in the current code.
>
> There are a bunch of minor checkpatch complaints as all touched lines
> haven't been fully converted to the proper brace style but I avoided
> do that to make the patch more readable.
>
> The following patches need review:
>    01 - fpu replace LIT64 usage with UINT64_C for special
>    02 - fpu convert float 16 32 64 _squash_denormal to ne
>    03 - fpu optimise float 16 32 64 _squash_denormal HACK
>    04 - fpu use min max values from stdint.h for integral
>    05 - fpu replace LIT64 with UINT64_C macros
>    06 - target m68k replace LIT64 with UINT64_C macros
>    07 - fpu remove the LIT64 macro

Richard had comments on PATCH 02+03.  Should I expect v4?

I'm asking because my '[PATCH v4 00/29] Tame a few "touch this,
recompile the world" headers' is ready, and I want to post the pull
request before it goes stale.  If this series is also ready, I can do
both together.  Else, it'll needs a rebase onto mine (one conflict,
resolving it necessitates a commit message update).