[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 11/15] paaudio: fix playback glitches
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 11/15] paaudio: fix playback glitches |
Date: |
Tue, 13 Aug 2019 13:18:05 +0200 |
From: Kővágó, Zoltán <address@hidden>
Pulseaudio normally assumes that when the server wants it, the client
can generate the audio samples and send it right away. Unfortunately
this is not the case with QEMU -- it's up to the emulated system when
does it generate the samples. Buffering the samples and sending them
from a background thread is just a workaround, that doesn't work too
well. Instead enable pa's compatibility support and let pa worry about
the details.
Signed-off-by: Kővágó, Zoltán <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>
---
audio/paaudio.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/audio/paaudio.c b/audio/paaudio.c
index f3864e1d5038..c8ae1a6eca01 100644
--- a/audio/paaudio.c
+++ b/audio/paaudio.c
@@ -512,10 +512,8 @@ static pa_stream *qpa_simple_new (
flags =
PA_STREAM_INTERPOLATE_TIMING
-#ifdef PA_STREAM_ADJUST_LATENCY
- | PA_STREAM_ADJUST_LATENCY
-#endif
- | PA_STREAM_AUTO_TIMING_UPDATE;
+ | PA_STREAM_AUTO_TIMING_UPDATE
+ | PA_STREAM_EARLY_REQUESTS;
if (dev) {
/* don't move the stream if the user specified a sink/source */
--
2.18.1
- [Qemu-devel] [PULL 00/15] Audio 20190813 patches, Gerd Hoffmann, 2019/08/13
- [Qemu-devel] [PULL 03/15] audio: add audiodev property to vnc and wav_capture, Gerd Hoffmann, 2019/08/13
- [Qemu-devel] [PULL 04/15] audio: add audiodev properties to frontends, Gerd Hoffmann, 2019/08/13
- [Qemu-devel] [PULL 07/15] paaudio: do not move stream when sink/source name is specified, Gerd Hoffmann, 2019/08/13
- [Qemu-devel] [PULL 09/15] audio: remove audio_MIN, audio_MAX, Gerd Hoffmann, 2019/08/13
- [Qemu-devel] [PULL 14/15] audio: fix memory leak reported by ASAN, Gerd Hoffmann, 2019/08/13
- [Qemu-devel] [PULL 05/15] paaudio: prepare for multiple audiodev, Gerd Hoffmann, 2019/08/13
- [Qemu-devel] [PULL 11/15] paaudio: fix playback glitches,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 02/15] audio: basic support for multi backend audio, Gerd Hoffmann, 2019/08/13
- [Qemu-devel] [PULL 08/15] paaudio: properly disconnect streams in fini_*, Gerd Hoffmann, 2019/08/13
- [Qemu-devel] [PULL 13/15] audio: use size_t where makes sense, Gerd Hoffmann, 2019/08/13
- [Qemu-devel] [PULL 06/15] audio: audiodev= parameters no longer optional when -audiodev present, Gerd Hoffmann, 2019/08/13
- [Qemu-devel] [PULL 15/15] audio: Add missing fall through comments, Gerd Hoffmann, 2019/08/13
- [Qemu-devel] [PULL 12/15] audio: remove read and write pcm_ops, Gerd Hoffmann, 2019/08/13
- [Qemu-devel] [PULL 10/15] audio: do not run each backend in audio_run, Gerd Hoffmann, 2019/08/13
- [Qemu-devel] [PULL 01/15] audio: reduce glob_audio_state usage, Gerd Hoffmann, 2019/08/13
- Re: [Qemu-devel] [PULL 00/15] Audio 20190813 patches, Peter Maydell, 2019/08/13