[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2] deal with BDRV_BLOCK_RAW
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH 0/2] deal with BDRV_BLOCK_RAW |
Date: |
Mon, 12 Aug 2019 21:46:29 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 12.08.19 20:11, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
>
> I'm not sure, is it a bug or a feature, but using qcow2 under raw is
> broken. It should be either fixed like I propose (by Max's suggestion)
> or somehow forbidden (just forbid backing-file supporting node to be
> file child of raw-format node).
I agree, I think only filters should return BDRV_BLOCK_RAW.
(And not even them, they should just be handled transparently by
bdrv_co_block_status(). But that’s something for later.)
> Vladimir Sementsov-Ogievskiy (2):
> block/raw-format: switch to BDRV_BLOCK_DATA with BDRV_BLOCK_RECURSE
> iotests: test mirroring qcow2 under raw format
>
> block/raw-format.c | 2 +-
> tests/qemu-iotests/263 | 46 ++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/263.out | 12 ++++++++++
> tests/qemu-iotests/group | 1 +
> 4 files changed, 60 insertions(+), 1 deletion(-)
> create mode 100755 tests/qemu-iotests/263
> create mode 100644 tests/qemu-iotests/263.out
Thanks, applied to my block-next branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block-next
Max
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH 2/2] iotests: test mirroring qcow2 under raw format, Vladimir Sementsov-Ogievskiy, 2019/08/12
Re: [Qemu-devel] [PATCH 0/2] deal with BDRV_BLOCK_RAW,
Max Reitz <=
- Re: [Qemu-devel] [PATCH 0/2] deal with BDRV_BLOCK_RAW, Max Reitz, 2019/08/12
- Re: [Qemu-devel] [PATCH 0/2] deal with BDRV_BLOCK_RAW, Vladimir Sementsov-Ogievskiy, 2019/08/13
- Re: [Qemu-devel] [PATCH 0/2] deal with BDRV_BLOCK_RAW, Vladimir Sementsov-Ogievskiy, 2019/08/13
- Re: [Qemu-devel] [PATCH 0/2] deal with BDRV_BLOCK_RAW, Vladimir Sementsov-Ogievskiy, 2019/08/13
- Re: [Qemu-devel] [PATCH 0/2] deal with BDRV_BLOCK_RAW, Vladimir Sementsov-Ogievskiy, 2019/08/13
- Re: [Qemu-devel] [PATCH 0/2] deal with BDRV_BLOCK_RAW, Kevin Wolf, 2019/08/13
- Re: [Qemu-devel] [PATCH 0/2] deal with BDRV_BLOCK_RAW, Vladimir Sementsov-Ogievskiy, 2019/08/13
- Re: [Qemu-devel] [PATCH 0/2] deal with BDRV_BLOCK_RAW, Max Reitz, 2019/08/13
- Re: [Qemu-devel] [PATCH 0/2] deal with BDRV_BLOCK_RAW, Vladimir Sementsov-Ogievskiy, 2019/08/13
- Re: [Qemu-devel] [PATCH 0/2] deal with BDRV_BLOCK_RAW, Max Reitz, 2019/08/13