[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] vdi: Make block_status recurse for fixed im
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] vdi: Make block_status recurse for fixed images |
Date: |
Mon, 12 Aug 2019 14:47:40 +0000 |
25.07.2019 18:55, Max Reitz wrote:
> Suggested-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> Fixes: 69f47505ee66afaa513305de0c1895a224e52c45
> Signed-off-by: Max Reitz <address@hidden>
Sorry for a delay, I thought that maintainers of the formats will approve these
patches ;)
Don't know vdi code, but it is what I suggested and seems to be the right thing
to do:
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> block/vdi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/block/vdi.c b/block/vdi.c
> index b9845a4cbd..40d40c34d5 100644
> --- a/block/vdi.c
> +++ b/block/vdi.c
> @@ -542,7 +542,8 @@ static int coroutine_fn
> vdi_co_block_status(BlockDriverState *bs,
> *map = s->header.offset_data + (uint64_t)bmap_entry * s->block_size +
> index_in_block;
> *file = bs->file->bs;
> - return BDRV_BLOCK_DATA | BDRV_BLOCK_OFFSET_VALID;
> + return BDRV_BLOCK_DATA | BDRV_BLOCK_OFFSET_VALID |
> + (s->header.image_type == VDI_TYPE_STATIC ? BDRV_BLOCK_RECURSE : 0);
> }
>
> static int coroutine_fn
>
--
Best regards,
Vladimir
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH 1/3] vdi: Make block_status recurse for fixed images,
Vladimir Sementsov-Ogievskiy <=