[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/7] ati-vga: Fix cursor color with guest_hwcurs
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 4/7] ati-vga: Fix cursor color with guest_hwcursor=true |
Date: |
Mon, 12 Aug 2019 11:03:35 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 8/11/19 11:14 PM, BALATON Zoltan wrote:
> Fixes: a38127414bd007c5b6ae64c664d9e8839393277e
> Signed-off-by: BALATON Zoltan <address@hidden>
> ---
> hw/display/ati.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/display/ati.c b/hw/display/ati.c
> index 699f38223b..b849f5d510 100644
> --- a/hw/display/ati.c
> +++ b/hw/display/ati.c
> @@ -207,7 +207,7 @@ static void ati_cursor_draw_line(VGACommonState *vga,
> uint8_t *d, int scr_y)
> }
> } else {
> color = (xbits & BIT(7) ? s->regs.cur_color1 :
> - s->regs.cur_color0) << 8 | 0xff;
> + s->regs.cur_color0) | 0xff000000;
> }
> if (vga->hw_cursor_x + i * 8 + j >= h) {
> return; /* end of screen, don't span to next line */
>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
- [Qemu-devel] [PATCH 0/7] Resend of all outstanding ati-vga patches, BALATON Zoltan, 2019/08/11
- [Qemu-devel] [PATCH 3/7] ati-vga: Fix GPIO_MONID register write, BALATON Zoltan, 2019/08/11
- [Qemu-devel] [PATCH 7/7] ati-vga: Add limited support for big endian frame buffer aperture, BALATON Zoltan, 2019/08/11
- [Qemu-devel] [PATCH 2/7] ati-vga: Add some register definitions for debugging, BALATON Zoltan, 2019/08/11
- [Qemu-devel] [PATCH 6/7] ati-vga: Attempt to handle CRTC offset not exact multiple of stride, BALATON Zoltan, 2019/08/11
- [Qemu-devel] [PATCH 5/7] ati-vga: Fix hardware cursor image offset, BALATON Zoltan, 2019/08/11
- [Qemu-devel] [PATCH 1/7] ati-vga: Add registers for getting apertures, BALATON Zoltan, 2019/08/11
- [Qemu-devel] [PATCH 4/7] ati-vga: Fix cursor color with guest_hwcursor=true, BALATON Zoltan, 2019/08/11
- Re: [Qemu-devel] [PATCH 4/7] ati-vga: Fix cursor color with guest_hwcursor=true,
Philippe Mathieu-Daudé <=