[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v6 08/42] block: bdrv_set_backing_hd() is about bs->
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH v6 08/42] block: bdrv_set_backing_hd() is about bs->backing |
Date: |
Fri, 9 Aug 2019 18:13:33 +0200 |
bdrv_set_backing_hd() is a function that explicitly cares about the
bs->backing child. Highlight that in its description and use
child_bs(bs->backing) instead of backing_bs(bs) to make it more obvious.
Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---
block.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block.c b/block.c
index 486c75d847..adf82efb0e 100644
--- a/block.c
+++ b/block.c
@@ -2539,7 +2539,7 @@ static bool bdrv_inherits_from_recursive(BlockDriverState
*child,
}
/*
- * Sets the backing file link of a BDS. A new reference is created; callers
+ * Sets the bs->backing link of a BDS. A new reference is created; callers
* which don't need their own reference any more must call bdrv_unref().
*/
void bdrv_set_backing_hd(BlockDriverState *bs, BlockDriverState *backing_hd,
@@ -2548,7 +2548,7 @@ void bdrv_set_backing_hd(BlockDriverState *bs,
BlockDriverState *backing_hd,
bool update_inherits_from = bdrv_chain_contains(bs, backing_hd) &&
bdrv_inherits_from_recursive(backing_hd, bs);
- if (bdrv_is_backing_chain_frozen(bs, backing_bs(bs), errp)) {
+ if (bdrv_is_backing_chain_frozen(bs, child_bs(bs->backing), errp)) {
return;
}
--
2.21.0
- [Qemu-devel] [PATCH v6 01/42] block: Mark commit and mirror as filter drivers, (continued)
- [Qemu-devel] [PATCH v6 01/42] block: Mark commit and mirror as filter drivers, Max Reitz, 2019/08/09
- [Qemu-devel] [PATCH v6 02/42] copy-on-read: Support compressed writes, Max Reitz, 2019/08/09
- [Qemu-devel] [PATCH v6 03/42] throttle: Support compressed writes, Max Reitz, 2019/08/09
- [Qemu-devel] [PATCH v6 05/42] block: Add chain helper functions, Max Reitz, 2019/08/09
- [Qemu-devel] [PATCH v6 06/42] qcow2: Implement .bdrv_storage_child(), Max Reitz, 2019/08/09
- [Qemu-devel] [PATCH v6 04/42] block: Add child access functions, Max Reitz, 2019/08/09
- [Qemu-devel] [PATCH v6 07/42] block: *filtered_cow_child() for *has_zero_init(), Max Reitz, 2019/08/09
- [Qemu-devel] [PATCH v6 08/42] block: bdrv_set_backing_hd() is about bs->backing,
Max Reitz <=
- [Qemu-devel] [PATCH v6 10/42] block: Drop bdrv_is_encrypted(), Max Reitz, 2019/08/09
- [Qemu-devel] [PATCH v6 09/42] block: Include filters when freezing backing chain, Max Reitz, 2019/08/09
- [Qemu-devel] [PATCH v6 11/42] block: Add bdrv_supports_compressed_writes(), Max Reitz, 2019/08/09
- [Qemu-devel] [PATCH v6 12/42] block: Use bdrv_filtered_rw* where obvious, Max Reitz, 2019/08/09
- [Qemu-devel] [PATCH v6 13/42] block: Use CAFs in block status functions, Max Reitz, 2019/08/09
- [Qemu-devel] [PATCH v6 14/42] block: Use CAFs when working with backing chains, Max Reitz, 2019/08/09