[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 14/29] migration: Move the VMStateDescription
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v2 14/29] migration: Move the VMStateDescription typedef to typedefs.h |
Date: |
Wed, 7 Aug 2019 19:13:59 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 8/6/19 5:14 PM, Markus Armbruster wrote:
> We declare incomplete struct VMStateDescription in a couple of places
> so we don't have to include migration/vmstate.h for the typedef.
> That's fine with me. However, the next commit will drop
> migration/vmstate.h from a massive number of compiles. Move the
> typedef to qemu/typedefs.h now, so I don't have to insert struct in
> front of VMStateDescription all over the place then.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> include/hw/qdev-core.h | 6 ++----
> include/migration/vmstate.h | 1 -
> include/qemu/typedefs.h | 1 +
> include/qom/cpu.h | 4 ++--
> target/alpha/cpu.h | 2 +-
> target/arm/cpu.h | 2 +-
> target/cris/cpu.h | 2 +-
> target/hppa/cpu.h | 2 +-
> target/i386/cpu.h | 2 +-
> target/lm32/cpu.h | 2 +-
> target/mips/internal.h | 2 +-
> target/openrisc/cpu.h | 2 +-
> target/ppc/cpu-qom.h | 2 +-
> target/ppc/cpu.h | 2 +-
> target/s390x/cpu.h | 2 +-
> target/sparc/cpu.h | 2 +-
> 16 files changed, 17 insertions(+), 19 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
- Re: [Qemu-devel] [PATCH v2 13/29] Clean up inclusion of exec/cpu-common.h, (continued)
[Qemu-devel] [PATCH v2 14/29] migration: Move the VMStateDescription typedef to typedefs.h, Markus Armbruster, 2019/08/06
[Qemu-devel] [PATCH v2 10/29] ide: Include hw/ide/internal a bit less outside hw/ide/, Markus Armbruster, 2019/08/06
[Qemu-devel] [PATCH v2 25/29] numa: Move remaining NUMA declarations from sysemu.h to numa.h, Markus Armbruster, 2019/08/06
[Qemu-devel] [PATCH v2 07/29] trace: Do not include qom/cpu.h into generated trace.h, Markus Armbruster, 2019/08/06
[Qemu-devel] [PATCH v2 17/29] Include qom/object.h slightly less, Markus Armbruster, 2019/08/06