[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 05/14] hw/machine: add helper to query the me
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v3 05/14] hw/machine: add helper to query the memory encryption state |
Date: |
Wed, 7 Aug 2019 17:14:32 +0100 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
* Singh, Brijesh (address@hidden) wrote:
> To enable a memory encryption inside a VM, user must pass the object
> name used for the encryption in command line parameter as shown below.
>
> # $(QEMU) \
> -machine memory-encryption=<object_name>
>
> Add a helper machine_memory_encryption_enabled() which will return a bool
> indicating whether the encryption object has been specified in the command
> line parameter.
>
> Signed-off-by: Brijesh Singh <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
There's a check in accel/kvm/kvm-all.c:kvm_init which has:
if (ms->memory_encryption) {
which you might want to replace by this.
Dave
> ---
> hw/core/machine.c | 5 +++++
> include/hw/boards.h | 1 +
> 2 files changed, 6 insertions(+)
>
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index c58a8e594e..f1e1b3661f 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -1031,6 +1031,11 @@ bool machine_mem_merge(MachineState *machine)
> return machine->mem_merge;
> }
>
> +bool machine_memory_encryption_enabled(MachineState *machine)
> +{
> + return machine->memory_encryption ? true : false;
> +}
> +
> static char *cpu_slot_to_string(const CPUArchId *cpu)
> {
> GString *s = g_string_new(NULL);
> diff --git a/include/hw/boards.h b/include/hw/boards.h
> index a71d1a53a5..c5446a39cf 100644
> --- a/include/hw/boards.h
> +++ b/include/hw/boards.h
> @@ -76,6 +76,7 @@ void machine_set_cpu_numa_node(MachineState *machine,
> Error **errp);
>
> void machine_class_allow_dynamic_sysbus_dev(MachineClass *mc, const char
> *type);
> +bool machine_memory_encryption_enabled(MachineState *machine);
>
>
> /**
> --
> 2.17.1
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
[Qemu-devel] [PATCH v3 05/14] hw/machine: add helper to query the memory encryption state, Singh, Brijesh, 2019/08/06
- Re: [Qemu-devel] [PATCH v3 05/14] hw/machine: add helper to query the memory encryption state,
Dr. David Alan Gilbert <=
[Qemu-devel] [PATCH v3 02/14] doc: update AMD SEV to include Live migration flow, Singh, Brijesh, 2019/08/06
[Qemu-devel] [PATCH v3 08/14] target/i386: sev: do not create launch context for an incoming guest, Singh, Brijesh, 2019/08/06
[Qemu-devel] [PATCH v3 07/14] target/i386: sev: provide callback to setup outgoing context, Singh, Brijesh, 2019/08/06
[Qemu-devel] [PATCH v3 06/14] hw/machine: introduce MachineMemoryEncryptionOps for encrypted VMs, Singh, Brijesh, 2019/08/06
[Qemu-devel] [PATCH v3 10/14] target/i386: sev: add support to load incoming encrypted page, Singh, Brijesh, 2019/08/06