[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 19/26] exec: Delete DEVICE_HOST_ENDIAN
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v6 19/26] exec: Delete DEVICE_HOST_ENDIAN |
Date: |
Wed, 7 Aug 2019 08:03:44 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 8/7/19 3:22 AM, Paolo Bonzini wrote:
> On 07/08/19 10:32, address@hidden wrote:
>> +#if defined(HOST_WORDS_BIGENDIAN)
>> + .endianness = MO_BE,
>> +#else
>> + .endianness = MO_LE,
>> +#endif
>
> Host endianness is just 0, isn't it?
Yes. Just leaving a comment to that effect here for the one use is probably
sufficient.
r~
- [Qemu-devel] [PATCH v6 14/26] exec: Hard code size with MO_{8|16|32|64}, (continued)
- [Qemu-devel] [PATCH v6 14/26] exec: Hard code size with MO_{8|16|32|64}, tony.nguyen, 2019/08/07
- [Qemu-devel] [PATCH v6 16/26] exec: Map device_endian onto MemOp, tony.nguyen, 2019/08/07
- [Qemu-devel] [PATCH v6 18/26] exec: Delete device_endian, tony.nguyen, 2019/08/07
- [Qemu-devel] [PATCH v6 19/26] exec: Delete DEVICE_HOST_ENDIAN, tony.nguyen, 2019/08/07
- [Qemu-devel] [PATCH v6 15/26] build: Correct non-common common-obj-* to obj-*, tony.nguyen, 2019/08/07
- [Qemu-devel] [PATCH v6 20/26] memory: Access MemoryRegion with endianness, tony.nguyen, 2019/08/07
- [Qemu-devel] [PATCH v6 23/26] cpu: TLB_FLAGS_MASK bit to force memory slow path, tony.nguyen, 2019/08/07
- [Qemu-devel] [PATCH v6 24/26] cputlb: Byte swap memory transaction attribute, tony.nguyen, 2019/08/07
- [Qemu-devel] [PATCH v6 22/26] memory: Single byte swap along the I/O path, tony.nguyen, 2019/08/07