[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 07/17] blockdev: adds bdrv_parse_aio to use i
From: |
Julia Suvorova |
Subject: |
Re: [Qemu-devel] [PATCH v9 07/17] blockdev: adds bdrv_parse_aio to use io_uring |
Date: |
Wed, 7 Aug 2019 14:49:51 +0200 |
On Wed, Aug 7, 2019 at 2:06 PM Aarushi Mehta <address@hidden> wrote:
>
>
>
> On Wed, 7 Aug, 2019, 17:15 Julia Suvorova, <address@hidden> wrote:
>>
>> On Fri, Aug 2, 2019 at 1:41 AM Aarushi Mehta <address@hidden> wrote:
>> > +int bdrv_parse_aio(const char *mode, int *flags)
>> > +{
>> > + if (!strcmp(mode, "threads")) {
>> > + /* do nothing, default */
>> > + } else if (!strcmp(mode, "native")) {
>> > + *flags |= BDRV_O_NATIVE_AIO;
>>
>> This 'if' should be covered with CONFIG_LINUX_AIO.
>
>
> The aio=native definition is shared with Windows hosts' native aio and will
> break if it was covered.
>
> file-posix handles the case.
Fair enough. Then you can remove all ifdefs for io_uring from
raw_open_common in file-posix.c as this case was already checked here.
Best regards, Julia Suvorova.
>> > +#ifdef CONFIG_LINUX_IO_URING
>> > + } else if (!strcmp(mode, "io_uring")) {
>> > + *flags |= BDRV_O_IO_URING;
>> > +#endif
>> > + } else {
>> > + return -1;
>> > + }
>> > +
>> > + return 0;
>> > +}
- [Qemu-devel] [PATCH v9 01/17] configure: permit use of io_uring, (continued)
- [Qemu-devel] [PATCH v9 01/17] configure: permit use of io_uring, Aarushi Mehta, 2019/08/01
- [Qemu-devel] [PATCH v9 02/17] qapi/block-core: add option for io_uring, Aarushi Mehta, 2019/08/01
- [Qemu-devel] [PATCH v9 03/17] block/block: add BDRV flag for io_uring, Aarushi Mehta, 2019/08/01
- [Qemu-devel] [PATCH v9 04/17] block/io_uring: implements interfaces for io_uring, Aarushi Mehta, 2019/08/01
- [Qemu-devel] [PATCH v9 05/17] stubs: add stubs for io_uring interface, Aarushi Mehta, 2019/08/01
- [Qemu-devel] [PATCH v9 06/17] util/async: add aio interfaces for io_uring, Aarushi Mehta, 2019/08/01
- [Qemu-devel] [PATCH v9 07/17] blockdev: adds bdrv_parse_aio to use io_uring, Aarushi Mehta, 2019/08/01
- [Qemu-devel] [PATCH v9 08/17] block/file-posix.c: extend to use io_uring, Aarushi Mehta, 2019/08/01
- [Qemu-devel] [PATCH v9 09/17] block: add trace events for io_uring, Aarushi Mehta, 2019/08/01
- [Qemu-devel] [PATCH v9 10/17] block/io_uring: adds userspace completion polling, Aarushi Mehta, 2019/08/01
- [Qemu-devel] [PATCH v9 11/17] qemu-io: adds option to use aio engine, Aarushi Mehta, 2019/08/01
- [Qemu-devel] [PATCH v9 12/17] qemu-img: adds option to use aio engine for benchmarking, Aarushi Mehta, 2019/08/01
- [Qemu-devel] [PATCH v9 13/17] qemu-nbd: adds option for aio engines, Aarushi Mehta, 2019/08/01
- [Qemu-devel] [PATCH v9 14/17] tests/qemu-iotests: enable testing with aio options, Aarushi Mehta, 2019/08/01
- [Qemu-devel] [PATCH v9 15/17] tests/qemu-iotests: use AIOMODE with various tests, Aarushi Mehta, 2019/08/01