[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] iotests: Enable -d for Python non-unittest
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] iotests: Enable -d for Python non-unittest tests |
Date: |
Tue, 6 Aug 2019 11:51:06 +0200 |
User-agent: |
Mutt/1.11.3 (2019-02-01) |
Am 06.08.2019 um 00:19 hat John Snow geschrieben:
>
>
> On 8/2/19 10:07 AM, Kevin Wolf wrote:
> > Am 01.08.2019 um 19:57 hat Max Reitz geschrieben:
> >> On 01.08.19 17:17, Kevin Wolf wrote:
> >>> The part of iotests.main() that is related to the implementation of the
> >>> debug option -d and enables QEMU and QMP logging is not only useful in
> >>> tests that use the Python unittest framework, but also in tests that
> >>> work by comparing with a reference output.
> >>>
> >>> Factor these parts out into iotests.init() and call it from the test
> >>> cases that currently lack support for debug output.
> >>
> >> How does this relate to
> >> https://lists.nongnu.org/archive/html/qemu-block/2019-07/msg01212.html ?
> >
> > Hm, no idea? :-)
> >
> > Looks like John's patch depends on some other patches which would then
> > conflict with mine, too, so maybe I'll just drop my patch and wait what
> > happens?
> >
> > John, any opinion?
> >
> > Kevin
> >
>
> My patches do roughly the same plus a little more. If you don't mind
> waiting, I can take care of this for you when the tree reopens?
Okay, I'll drop my patch then.
Kevin
[Qemu-devel] [PATCH 3/3] iotests: Test migration with all kinds of filter nodes, Kevin Wolf, 2019/08/01