[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] hmp: Remove migration capabilities from "inf
From: |
Wei Yang |
Subject: |
Re: [Qemu-devel] [PATCH v2] hmp: Remove migration capabilities from "info migrate" |
Date: |
Tue, 6 Aug 2019 08:35:19 +0800 |
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On Mon, Aug 05, 2019 at 12:12:25PM +0100, Dr. David Alan Gilbert wrote:
>* Wei Yang (address@hidden) wrote:
>> With the growth of migration capabilities, it is not proper to display
>> them in "info migrate". Users are recommended to use "info
>> migrate_capabiltiies" to list them.
>>
>> Signed-off-by: Wei Yang <address@hidden>
>> Suggested-by: Dr. David Alan Gilbert <address@hidden>
>>
>> ---
>> v2:
>> * remove capabilities from "info migrate"
>> ---
>> monitor/hmp-cmds.c | 13 +------------
>> 1 file changed, 1 insertion(+), 12 deletions(-)
>>
>> diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
>> index 99ceb0846b..05a09987da 100644
>> --- a/monitor/hmp-cmds.c
>> +++ b/monitor/hmp-cmds.c
>> @@ -220,24 +220,13 @@ static char *SocketAddress_to_str(SocketAddress *addr)
>> void hmp_info_migrate(Monitor *mon, const QDict *qdict)
>> {
>> MigrationInfo *info;
>> - MigrationCapabilityStatusList *caps, *cap;
>> + MigrationCapabilityStatusList *caps;
>>
>> info = qmp_query_migrate(NULL);
>> caps = qmp_query_migrate_capabilities(NULL);
>
>Why keep 'caps' and query them? Can't this go as well?
You are right. Let me remove it.
--
Wei Yang
Help you, Help me