[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 17/17] block/io_uring: enable kernel submissi
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH v9 17/17] block/io_uring: enable kernel submission polling |
|
Date: |
Mon, 5 Aug 2019 09:29:54 +0100 |
On Fri, Aug 2, 2019 at 12:50 AM Aarushi Mehta <address@hidden> wrote:
> + rc = io_uring_queue_init(MAX_EVENTS, ring, IORING_SETUP_SQPOLL);
> + if (rc == -EOPNOTSUPP) {
> + rc = io_uring_queue_init(MAX_EVENTS, ring, 0);
> + }
IORING_SETUP_SQPOLL is only allowed when the user has CAP_SYS_ADMIN
(e.g. they are root). Otherwise it fails with -EPERM.
This patch breaks non-root QEMU usage. Please handle -EPERM like
-EOPNOTSUPP so it falls back to non-polling mode.
Stefan
- Re: [Qemu-devel] [PATCH v9 11/17] qemu-io: adds option to use aio engine, (continued)
- [Qemu-devel] [PATCH v9 12/17] qemu-img: adds option to use aio engine for benchmarking, Aarushi Mehta, 2019/08/01
- [Qemu-devel] [PATCH v9 13/17] qemu-nbd: adds option for aio engines, Aarushi Mehta, 2019/08/01
- [Qemu-devel] [PATCH v9 14/17] tests/qemu-iotests: enable testing with aio options, Aarushi Mehta, 2019/08/01
- [Qemu-devel] [PATCH v9 15/17] tests/qemu-iotests: use AIOMODE with various tests, Aarushi Mehta, 2019/08/01
- [Qemu-devel] [PATCH v9 16/17] block/io_uring: adds fd registration, Aarushi Mehta, 2019/08/01
- [Qemu-devel] [PATCH v9 17/17] block/io_uring: enable kernel submission polling, Aarushi Mehta, 2019/08/01