[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for 4.2 v5 07/12] target/mips: Style improvement
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH for 4.2 v5 07/12] target/mips: Style improvements in cpu.c |
Date: |
Fri, 2 Aug 2019 18:09:03 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 8/1/19 6:45 PM, Aleksandar Markovic wrote:
> From: Aleksandar Markovic <address@hidden>
>
> Fixes mostly errors and warings reported by 'checkpatch.pl -f'.
"warnings"
>
> Signed-off-by: Aleksandar Markovic <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> target/mips/cpu.c | 17 +++++++++++------
> 1 file changed, 11 insertions(+), 6 deletions(-)
>
> diff --git a/target/mips/cpu.c b/target/mips/cpu.c
> index 39eafaf..3ffa342 100644
> --- a/target/mips/cpu.c
> +++ b/target/mips/cpu.c
> @@ -57,9 +57,11 @@ static bool mips_cpu_has_work(CPUState *cs)
> CPUMIPSState *env = &cpu->env;
> bool has_work = false;
>
> - /* Prior to MIPS Release 6 it is implementation dependent if non-enabled
> - interrupts wake-up the CPU, however most of the implementations only
> - check for interrupts that can be taken. */
> + /*
> + * Prior to MIPS Release 6 it is implementation dependent if non-enabled
> + * interrupts wake-up the CPU, however most of the implementations only
> + * check for interrupts that can be taken.
> + */
> if ((cs->interrupt_request & CPU_INTERRUPT_HARD) &&
> cpu_mips_hw_interrupts_pending(env)) {
> if (cpu_mips_hw_interrupts_enabled(env) ||
> @@ -70,8 +72,10 @@ static bool mips_cpu_has_work(CPUState *cs)
>
> /* MIPS-MT has the ability to halt the CPU. */
> if (env->CP0_Config3 & (1 << CP0C3_MT)) {
> - /* The QEMU model will issue an _WAKE request whenever the CPUs
> - should be woken up. */
> + /*
> + * The QEMU model will issue an _WAKE request whenever the CPUs
> + * should be woken up.
> + */
> if (cs->interrupt_request & CPU_INTERRUPT_WAKE) {
> has_work = true;
> }
> @@ -112,7 +116,8 @@ static void mips_cpu_reset(CPUState *s)
> #endif
> }
>
> -static void mips_cpu_disas_set_info(CPUState *s, disassemble_info *info) {
> +static void mips_cpu_disas_set_info(CPUState *s, disassemble_info *info)
> +{
> MIPSCPU *cpu = MIPS_CPU(s);
> CPUMIPSState *env = &cpu->env;
>
>
- [Qemu-devel] [PATCH for 4.2 v5 04/12] target/mips: Add support for emulation of GINVT instruction, (continued)
- [Qemu-devel] [PATCH for 4.2 v5 04/12] target/mips: Add support for emulation of GINVT instruction, Aleksandar Markovic, 2019/08/01
- [Qemu-devel] [PATCH for 4.2 v5 05/12] target/mips: Add support for emulation of CRC32 group of instructions, Aleksandar Markovic, 2019/08/01
- [Qemu-devel] [PATCH for 4.2 v5 09/12] target/mips: Style improvements in internal.h, Aleksandar Markovic, 2019/08/01
- [Qemu-devel] [PATCH for 4.2 v5 10/12] target/mips: Style improvements in machine.c, Aleksandar Markovic, 2019/08/01
- [Qemu-devel] [PATCH for 4.2 v5 08/12] target/mips: Style improvements in helper.c, Aleksandar Markovic, 2019/08/01
- [Qemu-devel] [PATCH for 4.2 v5 06/12] target/mips: Style improvements in cp0_timer.c, Aleksandar Markovic, 2019/08/01
- [Qemu-devel] [PATCH for 4.2 v5 07/12] target/mips: Style improvements in cpu.c, Aleksandar Markovic, 2019/08/01
- Re: [Qemu-devel] [PATCH for 4.2 v5 07/12] target/mips: Style improvements in cpu.c,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH for 4.2 v5 11/12] tests/tcg: target/mips: Add optional printing of more detailed failure info, Aleksandar Markovic, 2019/08/01
- [Qemu-devel] [PATCH for 4.2 v5 12/12] tests/tcg: target/mips: Fix target configurations for MSA tests, Aleksandar Markovic, 2019/08/01