[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 24/28] Include sysemu/hostmem.h less
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH 24/28] Include sysemu/hostmem.h less |
|
Date: |
Fri, 02 Aug 2019 15:20:56 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
> On 26/07/19 14:05, Markus Armbruster wrote:
>> Move the HostMemoryBackend typedef from sysemu/hostmem.h to
>> qemu/typedefs.h. This renders a few inclusions of sysemu/hostmem.h
>> superflouous; drop them.
>
> I think this can also qualify for qemu/typedefs.h, even though this
> patch is also into diminishing returns (sysemu/hostmem.h is only
> included in a dozen files).
Yes, hostmem.h is fairly harmless: ~250 out of 6600 objects in my "build
everything" tree before this patch, 130 after, 110 after the next one.
If I remember correctly, this patch helps making the remaining ones
strict improvements, i.e. counts go only down.
Since you don't seem to mind, I'll keep it.