Re: [Qemu-devel] [PATCH 27/28] sysemu: Move the VMChangeStateEntry typedef to qemu/typedefs.h

[Markus Armbruster]

Paolo Bonzini <address@hidden> writes:

> On 26/07/19 14:05, Markus Armbruster wrote:
>> +typedef struct VMChangeStateEntry VMChangeStateEntry;
>>  typedef struct VMStateDescription VMStateDescription;
>>  
>
> This is a bit borderline; I'd rather split sysemu/sysemu.h, e.g. adding
> sysemu/runstate.h that would have VMChangeStateEntry functions.  If
> there aren't many conflicts, perhaps you can drop this patch?

Without it, the next one will be ineffective.

Which parts of sysemu.h would you rather move to runstate.h?

* VMChangeStateEntry and the three functions using it, obviously, along
  with VMChangeStateHandler.

* vm_state_notify(), because it belongs to the above.

* The runstate_FOO() functions, because they're named like the new
  header?

* vm_stop(), vm_stop_force_state(), vmstop_requested(),
  vmstop_requested, because they use RunState?

* The remaining vm_FOO(), because they're closely related to vm_stop()?

* Everything else from qemu_exit_preconfig_request() to
  qemu_remove_exit_notifier(), along with WakeupReason?

* More?

If only the first two, we can call the new header vmstate-notify.h.