[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] migration: always initial RAMBlock.bmap to 1 fo
|
From: |
Wei Yang |
|
Subject: |
Re: [Qemu-devel] [PATCH] migration: always initial RAMBlock.bmap to 1 for new migration |
|
Date: |
Fri, 2 Aug 2019 08:50:40 +0800 |
|
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On Thu, Aug 01, 2019 at 03:58:54PM +0800, Ivan Ren wrote:
>>>- * Here we didn't set RAMBlock.bmap simply because it is
>already
>>>- * set in ram_list.dirty_memory[DIRTY_MEMORY_MIGRATION] in
>>>- * ram_block_add, and that's where we'll sync the dirty
>bitmaps.
>>>- * Here setting RAMBlock.bmap would be fine too but not
>necessary.
>>>+ * Here we set RAMBlock.bmap all to 1 because when rebegin a
>>>+ * new migration after a failed migration, ram_list.
>>
>>It is after failure or cancel?
>
>Here we can treat cancel as a special fail.
>
Well, I am not sure this is officially documented. Would this lead to
confusion?
>Thanks.
>
--
Wei Yang
Help you, Help me