[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/7] target/sparc: Handle bus errors in mmu_prob
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 5/7] target/sparc: Handle bus errors in mmu_probe() |
Date: |
Thu, 1 Aug 2019 13:40:58 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 8/1/19 11:30 AM, Peter Maydell wrote:
> + /*
> + * TODO: MMU probe operations are supposed to set the fault
> + * status registers, but we don't do this.
> + */
Well, the todo should be using sparc_cpu_tlb_fill with probe=true, since this
function appears to be otherwise redundant. Of course, there's currently a big
fixme for that as well.
In the meantime, this does one step better than before.
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [PATCH 0/7] target/sparc: Convert to do_transaction_failed hook, Peter Maydell, 2019/08/01
- [Qemu-devel] [PATCH 6/7] target/sparc: Remove unused ldl_phys from dump_mmu(), Peter Maydell, 2019/08/01
- [Qemu-devel] [PATCH 5/7] target/sparc: Handle bus errors in mmu_probe(), Peter Maydell, 2019/08/01
- Re: [Qemu-devel] [PATCH 5/7] target/sparc: Handle bus errors in mmu_probe(),
Richard Henderson <=
- [Qemu-devel] [PATCH 3/7] target/sparc: Check for transaction failures in MXCC stream ASI accesses, Peter Maydell, 2019/08/01
- [Qemu-devel] [PATCH 2/7] target/sparc: Check for transaction failures in MMU passthrough ASIs, Peter Maydell, 2019/08/01
- [Qemu-devel] [PATCH 4/7] target/sparc: Correctly handle bus errors in page table walks, Peter Maydell, 2019/08/01
- [Qemu-devel] [PATCH 7/7] target/sparc: Switch to do_transaction_failed() hook, Peter Maydell, 2019/08/01
- [Qemu-devel] [PATCH 1/7] target/sparc: Factor out the body of sparc_cpu_unassigned_access(), Peter Maydell, 2019/08/01