[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 15/54] plugin: add implementation of the api
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v4 15/54] plugin: add implementation of the api |
Date: |
Thu, 1 Aug 2019 09:14:03 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 7/31/19 9:06 AM, Alex Bennée wrote:
> +uint64_t qemu_plugin_hwaddr_to_raddr(const struct qemu_plugin_hwaddr *haddr)
> +{
> +#if 0 /* XXX FIXME should be SOFTMMU */
> + ram_addr_t ram_addr;
> +
> + g_assert(haddr);
> + ram_addr = qemu_ram_addr_from_host(haddr);
> + if (ram_addr == RAM_ADDR_INVALID) {
> + error_report("Bad ram pointer %p", haddr);
> + abort();
> + }
> + return ram_addr;
> +#else
> + return 0;
> +#endif
> +}
What would a plugin do with an raddr? This seems like a qemu internal thing,
and not really related to anything that the plugin could match up to the hw.
Otherwise,
Reviewed-by: Richard Henderson <address@hidden>
r~
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v4 15/54] plugin: add implementation of the api,
Richard Henderson <=