[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 07/54] trace: add mmu_index to mem_info
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v4 07/54] trace: add mmu_index to mem_info |
Date: |
Thu, 1 Aug 2019 08:17:37 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 7/31/19 9:06 AM, Alex Bennée wrote:
> We are going to re-use mem_info later for plugins and will need to
> track the mmu_idx for softmmu code.
>
> [TODO: convert everything to use TCGMemOpIdx?]
Probably easier. At the moment,
> +#define ATOMIC_MMU_IDX oi
this is mis-named. It works because
> static inline
> -uint8_t trace_mem_build_info_no_se_le(int size_shift, bool store)
> +uint16_t trace_mem_build_info_no_se_le(int size_shift, bool store,
> + TCGMemOpIdx oi)
> {
> - return trace_mem_build_info(size_shift, false, MO_LE, store);
> + return trace_mem_build_info(size_shift, false, MO_LE, store,
> + get_mmuidx(oi));
> }
you're also inconsistent about the arguments between user-only and softmmu.
Without doing everything, maybe just use
#define ATOMIC_MMU_IDX get_mmuidx(oi)
?
r~
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v4 07/54] trace: add mmu_index to mem_info,
Richard Henderson <=