[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 01/11] monitor: Remove unused password prompt
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 01/11] monitor: Remove unused password prompting fields |
Date: |
Wed, 12 Jun 2019 08:43:18 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Kevin Wolf <address@hidden> writes:
> Commit 788cf9f8c removed the code for password prompting from the
> monitor. Since then, the Monitor fields password_completion_cb and
> password_opaque have been unused. Remove them.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> monitor.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/monitor.c b/monitor.c
> index 6428eb3b7e..70ce9e8a77 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -220,8 +220,6 @@ struct Monitor {
>
> MonitorQMP qmp;
> gchar *mon_cpu_path;
> - BlockCompletionFunc *password_completion_cb;
> - void *password_opaque;
> mon_cmd_t *cmd_table;
> QTAILQ_ENTRY(Monitor) entry;
Reviewed-by: Markus Armbruster <address@hidden>
- [Qemu-devel] [PATCH v2 00/11] monitor: Split monitor.c in core/HMP/QMP/misc, Kevin Wolf, 2019/06/11
- [Qemu-devel] [PATCH v2 02/11] monitor: Split monitor_init in HMP and QMP function, Kevin Wolf, 2019/06/11
- [Qemu-devel] [PATCH v2 01/11] monitor: Remove unused password prompting fields, Kevin Wolf, 2019/06/11
- Re: [Qemu-devel] [PATCH v2 01/11] monitor: Remove unused password prompting fields,
Markus Armbruster <=
- [Qemu-devel] [PATCH v2 04/11] monitor: Create MonitorHMP with readline state, Kevin Wolf, 2019/06/11
- Re: [Qemu-devel] [PATCH v2 04/11] monitor: Create MonitorHMP with readline state, Markus Armbruster, 2019/06/12
- Re: [Qemu-devel] [PATCH v2 04/11] monitor: Create MonitorHMP with readline state, Peter Xu, 2019/06/12
- Re: [Qemu-devel] [PATCH v2 04/11] monitor: Create MonitorHMP with readline state, Kevin Wolf, 2019/06/12
- Re: [Qemu-devel] [PATCH v2 04/11] monitor: Create MonitorHMP with readline state, Markus Armbruster, 2019/06/12
- Re: [Qemu-devel] [PATCH v2 04/11] monitor: Create MonitorHMP with readline state, Dr. David Alan Gilbert, 2019/06/12
- Re: [Qemu-devel] [PATCH v2 04/11] monitor: Create MonitorHMP with readline state, Kevin Wolf, 2019/06/12
- [Qemu-devel] [PATCH v2 05/11] monitor: Move cmd_table to MonitorHMP, Kevin Wolf, 2019/06/11