|
| From: | Markus Armbruster |
| Subject: | Re: [Qemu-devel] [PATCH v2 15/17] monitor: Clean up how monitor_disas() funnels output to monitor |
| Date: | Thu, 18 Apr 2019 08:20:26 +0200 |
| User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Eric Blake <address@hidden> writes: > On 4/17/19 2:18 PM, Markus Armbruster wrote: >> INIT_DISASSEMBLE_INFO() takes an fprintf()-like callback and a FILE * >> to pass to it. monitor_disas() passes monitor_fprintf() and the >> current monitor cast to FILE *. monitor_fprintf() casts it right >> back, and is otherwise identical to monitor_printf(). The >> type-pinning is ugly. > > For consistency with other patches in the series, s/pinning/punning/ Typo, will fix. Thanks! >> >> Pass qemu_fprintf() and NULL instead. >> >> monitor_fprintf() is now unused; delete it. >> >> Signed-off-by: Markus Armbruster <address@hidden> >> Reviewed-by: Dr. David Alan Gilbert <address@hidden> >> ---
| [Prev in Thread] | Current Thread | [Next in Thread] |