Re: [Qemu-devel] [multiprocess RFC PATCH 35/37] multi-process: QMP/HMP commands to resize block device on remote process

[Elena Ufimtseva]

On Thu, Mar 07, 2019 at 10:15:36AM -0600, Eric Blake wrote:
> On 3/7/19 1:22 AM, address@hidden wrote:
> > From: Jagannathan Raman <address@hidden>
> > 
> > Adds rblock_resize QMP/HMP commands to resize block devices on the remote
> > process.
> > 
> > Signed-off-by: John G Johnson <address@hidden>
> > Signed-off-by: Jagannathan Raman <address@hidden>
> > Signed-off-by: Elena Ufimtseva <address@hidden>
> > ---
> 
> I know the discussion is questioning whether this is even the right way
> to go, but if we DO add a QMP command,
> 
> > +++ b/qapi/block-core.json
> > @@ -1260,6 +1260,31 @@
> >              'size': 'int' } }
> >  
> >  ##
> > +# @rblock_resize:
> 
> It should be named 'rblock-resize'
>

Ok. 
> > +#
> > +# Resize a block image while a guest is running, on a remote device.
> > +#
> > +# @device: the name of the device to get the image resized
> > +#
> > +# @size:  new image size in bytes
> > +#
> > +# Returns: nothing on success
> > +#          If @device is not a valid block device, DeviceNotFound
> > +#
> > +# Since: 3.0.93
> 
> and you've missed 3.0 (if you got it in THIS week, it would be Since
> 4.0; but that's unlikely, so you want Since 4.1).

Got it,

Thanks Eric!

Elena
> 
> -- 
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3226
> Virtualization:  qemu.org | libvirt.org
>