Re: [Qemu-devel] [PATCH 7/7] qapi: Fix array first used in a different module

[Eric Blake]

On 3/1/19 9:40 AM, Markus Armbruster wrote:
> We generally put implicitly defined types in whatever module triggered
> their definition.  This is wrong for array types, as the included test
> case demonstrates.  Let's have a closer look at it.
> 
> Type 'Status' is defined sub-sub-module.json.  Array type ['Status']
> occurs in main module qapi-schema-test.json and in
> include/sub-module.json.  The main module's use is first, so the array
> type gets put into the main module.
> 
> The generated C headers define StatusList in qapi-types.h.  But
> include/qapi-types-sub-module.h uses it without including
> qapi-types.h.  Oops.
> 
> To fix that, put the array type into its element type's module.
> 
> Now StatusList gets generated into qapi-types-sub-module.h, which all
> its users include.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---

Yay! One less hack in .qapi files where we had to use dummy structs to
work around awkward declaration locations.

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org