Re: [Qemu-devel] [PATCH v3 9/9] block: Make auto-read-only=on default for -drive

[Eric Blake]

On 10/17/18 11:42 AM, Kevin Wolf wrote:
> While we want machine interfaces like -blockdev and QMP blockdev-add to
> add as little auto-detection as possible so that management tools are
> explicit about their needs, -drive is a convenience option for human
> users. Enabling auto-read-only=on by default there enables users to use
> read-only images for read-only guest devices without having to specify
> read-only=on explicitly. If they try to attach the image to a read-write
> device, they will still get an error message.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>   blockdev.c | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Eric Blake <address@hidden>

However, the obligatory: "iotests coverage?"

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org