Re: [Qemu-devel] [PATCH] target/ppc: fix dcbz, dcbzep, dcbtst and insn type

[David Gibson]

On Fri, Sep 21, 2018 at 10:55:56AM +1000, David Gibson wrote:
> On Thu, Sep 20, 2018 at 01:17:59PM +0200, Roman Kapl wrote:
> > On 09/20/2018 01:13 PM, Philippe Mathieu-Daudé wrote:
> > > 
> > > > Fixes: ea8073c10d ("target/ppc: add external PID support")
> > > 
> > > Your previous patch is now d12a22c5c7 in David Gibson's tree, so I think
> > > here squashing your fixes (once this patch got reviewed) is the best 
> > > option.
> > 
> > You are right -- I've referenced the wrong tree. At least this needs to be
> > fixed if it won't be squashed.
> 
> I've squashed it into the original patch.

Well, I had squashed it, but it turns out the "corrected" version
breaks compile for the ppc64abi32-linux-user target.  Please remember
to do an all-targets build before sending patches.

For now I've pulled the whole thing from my tree, please send a v2
with the fixes folded in.

> For future reference, my ppc-for-3.1 branch is a rebasing tree, so
> SHAs in there can't be relied on to remain stable.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature