[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 01/16] checkpatch: Add xendevicemodel_handle to the
From: |
Ian Jackson |
Subject: |
[Qemu-devel] [PATCH 01/16] checkpatch: Add xendevicemodel_handle to the list of types |
Date: |
Tue, 24 Apr 2018 18:58:14 +0100 |
This avoids checkpatch misparsing (as statements) long function
definitions or declarations, which sometimes start with constructs
like this:
static inline int xendevicemodel_relocate_memory(
xendevicemodel_handle *dmod, domid_t domid, ...
The type xendevicemodel_handle does not conform to Qemu CODING_STYLE,
which would suggest CamelCase. However, it is a type defined by the
Xen Project in xen.git. It would be possible to introduce a typedef
to allow the qemu code to refer to it by a differently-spelled name,
but that would obfuscate more than it would clarify.
CC: Eric Blake <address@hidden>
CC: Paolo Bonzini <address@hidden>
CC: Daniel P. Berrange <address@hidden>
Signed-off-by: Ian Jackson <address@hidden>
---
v7: Added comment to commit message about why we are not renaming
this type to CamelCase.
v6.1: New patch
---
scripts/checkpatch.pl | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d52207a..5b8735d 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -266,6 +266,7 @@ our @typeList = (
qr{target_(?:u)?long},
qr{hwaddr},
qr{xml${Ident}},
+ qr{xendevicemodel_handle},
);
# This can be modified by sub possible. Since it can be empty, be careful
--
2.1.4
- [Qemu-devel] [PATCH v8 00/16] xen: xen-domid-restrict improvements, Ian Jackson, 2018/04/24
- [Qemu-devel] [PATCH 13/16] xen: Expect xenstore write to fail when restricted, Ian Jackson, 2018/04/24
- [Qemu-devel] [PATCH 11/16] xen: Use newly added dmops for mapping VGA memory, Ian Jackson, 2018/04/24
- [Qemu-devel] [PATCH 01/16] checkpatch: Add xendevicemodel_handle to the list of types,
Ian Jackson <=
- [Qemu-devel] [PATCH 02/16] AccelClass: Introduce accel_setup_post, Ian Jackson, 2018/04/24
- [Qemu-devel] [PATCH 04/16] xen: restrict: use xentoolcore_restrict_all, Ian Jackson, 2018/04/24
- [Qemu-devel] [PATCH 03/16] xen: link against xentoolcore, Ian Jackson, 2018/04/24
- [Qemu-devel] [PATCH 05/16] xen: defer call to xen_restrict until just before os_setup_post, Ian Jackson, 2018/04/24
- [Qemu-devel] [PATCH 09/16] os-posix: cleanup: Replace fprintfs with error_report in change_process_uid, Ian Jackson, 2018/04/24