[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 for-2.12 4/5] s390x/tcg: indicate value of TO
|
From: |
David Hildenbrand |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 for-2.12 4/5] s390x/tcg: indicate value of TODPR in STCKE |
|
Date: |
Fri, 8 Dec 2017 13:45:40 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 08.12.2017 01:02, Richard Henderson wrote:
> On 12/07/2017 07:31 AM, David Hildenbrand wrote:
>> + /* 16 bit value store in an uint32_t (only valid bits set) */
>> + tcg_gen_ld32u_i64(todpr, cpu_env, offsetof(CPUS390XState, todpr));
>
> Any reason not to use a uint16_t and use tcg_gen_ld16u_i64 here?
>
Yes, KVM introduced and uses this field. As it is used for migration, we
cannot easily change it. (any maybe it was designed that way for future
changes)
>
> r~
>
--
Thanks,
David / dhildenb