[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 07/24] block: Convert bdrv_get_block_status()
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v6 07/24] block: Convert bdrv_get_block_status() to bytes |
Date: |
Fri, 20 Oct 2017 17:31:00 +0200 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
Am 20.10.2017 um 17:12 hat Eric Blake geschrieben:
> On 10/20/2017 09:31 AM, Kevin Wolf wrote:
> > Am 12.10.2017 um 05:47 hat Eric Blake geschrieben:
> >> We are gradually moving away from sector-based interfaces, towards
> >> byte-based. In the common case, allocation is unlikely to ever use
> >> values that are not naturally sector-aligned, but it is possible
> >> that byte-based values will let us be more precise about allocation
> >> at the end of an unaligned file that can do byte-based access.
> >>
>
> >> *
> >> - * If BDRV_BLOCK_OFFSET_VALID is set, bits 9-62 (BDRV_BLOCK_OFFSET_MASK)
> >> - * represent the offset in the returned BDS that is allocated for the
> >> - * corresponding raw data; however, whether that offset actually contains
> >> - * data also depends on BDRV_BLOCK_DATA and BDRV_BLOCK_ZERO, as follows:
> >> + * If BDRV_BLOCK_OFFSET_VALID is set, bits 9-62 (BDRV_BLOCK_OFFSET_MASK)
> >> of
> >> + * the return value (old interface) or the entire map parameter (new
> >> + * interface) represent the offset in the returned BDS that is allocated
> >> for
> >> + * the corresponding raw data.
> >
> > Are there any functions using the old interface left at the end of the
> > series or do we want a final patch that removes the old interface from
> > the description?
>
> Done here, in series 4, where we get rid of the old interface in the
> drivers:
> https://lists.gnu.org/archive/html/qemu-devel/2017-10/msg02941.html
Oh, right, I forgot about the driver callbacks. Makes sense.
Kevin
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH v6 01/24] block: Allow NULL file for bdrv_get_block_status(), (continued)
- [Qemu-devel] [PATCH v6 01/24] block: Allow NULL file for bdrv_get_block_status(), Eric Blake, 2017/10/11
- [Qemu-devel] [PATCH v6 03/24] block: Make bdrv_round_to_clusters() signature more useful, Eric Blake, 2017/10/11
- [Qemu-devel] [PATCH v6 02/24] block: Add flag to avoid wasted work in bdrv_is_allocated(), Eric Blake, 2017/10/11
- [Qemu-devel] [PATCH v6 05/24] block: Switch bdrv_make_zero() to byte-based, Eric Blake, 2017/10/11
- [Qemu-devel] [PATCH v6 04/24] qcow2: Switch is_zero_sectors() to byte-based, Eric Blake, 2017/10/11
- [Qemu-devel] [PATCH v6 06/24] qemu-img: Switch get_block_status() to byte-based, Eric Blake, 2017/10/11
- [Qemu-devel] [PATCH v6 09/24] block: Switch BdrvCoGetBlockStatusData to byte-based, Eric Blake, 2017/10/11
- [Qemu-devel] [PATCH v6 07/24] block: Convert bdrv_get_block_status() to bytes, Eric Blake, 2017/10/11
- [Qemu-devel] [PATCH v6 11/24] block: Switch bdrv_co_get_block_status_above() to byte-based, Eric Blake, 2017/10/11
- [Qemu-devel] [PATCH v6 10/24] block: Switch bdrv_common_block_status_above() to byte-based, Eric Blake, 2017/10/11
- [Qemu-devel] [PATCH v6 08/24] block: Switch bdrv_co_get_block_status() to byte-based, Eric Blake, 2017/10/11
- [Qemu-devel] [PATCH v6 12/24] block: Convert bdrv_get_block_status_above() to bytes, Eric Blake, 2017/10/11
[Qemu-devel] [PATCH v6 13/24] qemu-img: Simplify logic in img_compare(), Eric Blake, 2017/10/11
[Qemu-devel] [PATCH v6 15/24] qemu-img: Add find_nonzero(), Eric Blake, 2017/10/11
[Qemu-devel] [PATCH v6 14/24] qemu-img: Speed up compare on pre-allocated larger file, Eric Blake, 2017/10/11