Re: [Qemu-devel] [PATCH v9 04/26] target: [tcg] Add generic translation framework

[Lluís Vilanova]

Richard Henderson writes:

> On 06/25/2017 01:59 AM, Lluís Vilanova wrote:
[...]
>> +
>> +        /* Early exit before breakpoint checks */
>> +        if (unlikely(db->is_jmp != DJ_NEXT)) {
>> +            break;
>> +        }

> This must be done at the end of the loop, not at the beginning of the next 
> loop,
> after we've already emitted insn_start for the following insn.

> That said, you already do have that check below, so what is this intended to 
> do?

Some targets (for now, arm-linux-user) need to finish the translation loop
before even the first instruction.


Cheers,
  Lluis