[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [V18 2/4] hw/i386/trace-events: Add AMD IOMMU trace eve
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [Qemu-devel] [V18 2/4] hw/i386/trace-events: Add AMD IOMMU trace events |
|
Date: |
Tue, 20 Sep 2016 16:25:59 +0300 |
On Tue, Sep 20, 2016 at 04:21:41PM +0300, David Kiarie wrote:
> > > +amdvi_mode_invalid(unsigned level, uint64_t addr)"error:
> translation
> > level 0x%"PRIu8" translating addr 0x%"PRIx64
>
> This is also wrong. Can you pls go over the traces?
>
>
> I think you might be looking the wrong patch here.
OK, must be the HTML in your mail messing things up.
Please post plain-text patches and I'll review.
>
> Also, you can check Peter Maydell's rejects of the pulls that
> included these patches.
>
>
> I did look at the reject. The initial code wasn't actually broken but that
> discussion wasn't really relevant since 'extract64/extract32' is more decent.
There were some failures around traces too though. Pls check them out.
--
MST