Re: [Qemu-devel] [PATCH] block/io: optimize bdrv_co_pwritev for small requests

[Paolo Bonzini]

On 24/05/2016 16:07, Peter Lieven wrote:
> 
> Oh, thanks, and the if block also too complicated. If I am right it should
> collapse to:
> 
>         if (bytes < align) {
>             qemu_iovec_add(&local_qiov, head_buf + bytes,
>                            align - bytes);
>             bytes = align;
>         }
> 
> Right?

Yes, that should work.  But add a comment because it's much more
mysterious than your v1 patch. :)

Even just

        /* We have read the tail already if the request is smaller
         * than one aligned block.
         */

Thanks,

Paolo