Re: [Qemu-devel] [PATCH 20/22] 9pfs: break out generic code from virtio-9p.{c, h}

[Wei Liu]

On Thu, Jan 07, 2016 at 05:47:30PM +0000, Wei Liu wrote:
> On Thu, Jan 07, 2016 at 10:58:28PM +0530, Aneesh Kumar K.V wrote:
> > Wei Liu <address@hidden> writes:
> > 
> > > On Thu, Jan 07, 2016 at 10:27:13PM +0530, Aneesh Kumar K.V wrote:
> > >> Wei Liu <address@hidden> writes:
> > >> 
> > >> > The vast majority of code in virtio-9p.c is actually generic code.
> > >> > Rename that file to 9p.c and move virtio specific code to
> > >> > virtio-9p-device.c. Rename virtio-9p.h to 9p.h and split out virtio
> > >> > specific code to new virtio-9p.h.
> > >> >
> > >> > Finally fix up virtio-pci.h header file inclusion.
> > >> >
> > >> > Note that V9fsState and V9fsPDU are still tied to virtio at the moment.
> > >> > They will be handled later.
> > >> 
> > >> Can you split this to smaller patches as done for others.
> > >> 
> > >
> > > I'm not sure what you're asking for. IMHO splitting out C and header
> > > file is better done in one single commit.
> > >
> > 
> > virtio-9p.h -> 9p.h one patch
> 
> This can be done.
> 
> > virtio_p9_push_and_notify . There is one other instance of that
> > conversion in the next patch
> 
> The next patch ("9pfs: factor out v9fs_device_{,un}realize_common
> ") doesn't touch virtio_p9_push_and_notify. What do I miss?
> 

I've made a patch to break out v9fs_9p_push_and_notify. I guess that's
what you want.

Wei.