[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 05/48] checkpatch: do not recommend qemu_strtok over
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 05/48] checkpatch: do not recommend qemu_strtok over strtok |
Date: |
Tue, 22 Sep 2015 17:05:28 +0200 |
If anything it should recommend strtok_r!
Signed-off-by: Paolo Bonzini <address@hidden>
---
scripts/checkpatch.pl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 574334b..b6d71ea 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2463,8 +2463,8 @@ sub process {
WARN("__func__ should be used instead of gcc specific
__FUNCTION__\n" . $herecurr);
}
-# recommend qemu_strto* over strto*
- if ($line =~ /\b(strto.*?)\s*\(/) {
+# recommend qemu_strto* over strto* for numeric conversions
+ if ($line =~ /\b(strto[^k].*?)\s*\(/) {
WARN("consider using qemu_$1 in preference to $1\n" .
$herecurr);
}
# check for module_init(), use category-specific init macros explicitly please
--
2.5.0
- [Qemu-devel] [PULL 00/48] Misc patches for 2015-09-22, Paolo Bonzini, 2015/09/22
- [Qemu-devel] [PULL 01/48] nbd: convert to use the QAPI SocketAddress object, Paolo Bonzini, 2015/09/22
- [Qemu-devel] [PULL 02/48] qemu-nbd: convert to use the QAPI SocketAddress object, Paolo Bonzini, 2015/09/22
- [Qemu-devel] [PULL 04/48] tests: add some qemu_strtosz() tests, Paolo Bonzini, 2015/09/22
- [Qemu-devel] [PULL 03/48] utils: rename strtosz to use qemu prefix, Paolo Bonzini, 2015/09/22
- [Qemu-devel] [PULL 05/48] checkpatch: do not recommend qemu_strtok over strtok,
Paolo Bonzini <=
- [Qemu-devel] [PULL 07/48] Makefile: fix build when VPATH is outside GIT tree, Paolo Bonzini, 2015/09/22
- [Qemu-devel] [PULL 06/48] scsi-generic: let guests recognize readonly=on on passthrough devices, Paolo Bonzini, 2015/09/22
- [Qemu-devel] [PULL 08/48] vhost-scsi: include linux/vhost.h, Paolo Bonzini, 2015/09/22
- [Qemu-devel] [PULL 10/48] MAINTAINERS: there is no PPC64 TCG backend anymore, Paolo Bonzini, 2015/09/22
- [Qemu-devel] [PULL 09/48] get_maintainer.pl: \C is deprecated, Paolo Bonzini, 2015/09/22
- [Qemu-devel] [PULL 11/48] MAINTAINERS: Add disassemblers to the various backends, Paolo Bonzini, 2015/09/22
- [Qemu-devel] [PULL 12/48] MAINTAINERS: Add more s390 files, Paolo Bonzini, 2015/09/22
- [Qemu-devel] [PULL 15/48] MAINTAINERS: add more devices to the PCI section, Paolo Bonzini, 2015/09/22
- [Qemu-devel] [PULL 16/48] MAINTAINERS: add maintainer for character device front-ends, Paolo Bonzini, 2015/09/22
- [Qemu-devel] [PULL 13/48] MAINTAINERS: add IPack section, Paolo Bonzini, 2015/09/22