[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 11/16] Add new block driver interfaces to contro
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 11/16] Add new block driver interfaces to control block replication |
Date: |
Wed, 2 Sep 2015 10:33:24 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 09/02/2015 02:51 AM, Wen Congyang wrote:
> Signed-off-by: Wen Congyang <address@hidden>
> Signed-off-by: zhanghailiang <address@hidden>
> Signed-off-by: Gonglei <address@hidden>
> Cc: Luiz Capitulino <address@hidden>
> Cc: Michael Roth <address@hidden>
> Reviewed-by: Paolo Bonzini <address@hidden>
> ---
> block.c | 43 +++++++++++++++++++++++++++++++++++++++++++
> include/block/block.h | 5 +++++
> include/block/block_int.h | 14 ++++++++++++++
> qapi/block-core.json | 15 +++++++++++++++
> 4 files changed, 77 insertions(+)
>
Just an interface review for now:
> +++ b/qapi/block-core.json
> @@ -1810,6 +1810,21 @@
> 'data': { '*export': 'str' } }
>
> ##
> +# @ReplicationMode
> +#
> +# An enumeration of replication modes.
> +#
> +# @unprotected: Replication is not started or after failover.
Maybe:
Replication is either not started, or has experienced failover.
> +#
> +# @primary: Primary mode, the vm's state will be sent to secondary QEMU.
> +#
> +# @secondary: Secondary mode, receive the vm's state from primary QEMU.
> +#
> +# Since: 2.4
You've missed 2.4; this should be 2.5.
> +##
> +{ 'enum' : 'ReplicationMode', 'data' : [ 'primary', 'secondary' ] }
Where is 'unprotected' in this list?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 06/16] quorum: allow ignoring child errors, (continued)
- [Qemu-devel] [PATCH 09/16] Allow creating backup jobs when opening BDS, Wen Congyang, 2015/09/02
- [Qemu-devel] [PATCH 05/16] introduce a new API qemu_opts_absorb_qdict_by_index(), Wen Congyang, 2015/09/02
- [Qemu-devel] [PATCH 08/16] block: make bdrv_put_ref_bh_schedule() as a public API, Wen Congyang, 2015/09/02
- [Qemu-devel] [PATCH 11/16] Add new block driver interfaces to control block replication, Wen Congyang, 2015/09/02
- Re: [Qemu-devel] [PATCH 11/16] Add new block driver interfaces to control block replication,
Eric Blake <=
- [Qemu-devel] [PATCH 12/16] skip nbd_target when starting block replication, Wen Congyang, 2015/09/02
- [Qemu-devel] [PATCH 13/16] quorum: implement block driver interfaces for block replication, Wen Congyang, 2015/09/02
- [Qemu-devel] [PATCH 10/16] docs: block replication's description, Wen Congyang, 2015/09/02
- [Qemu-devel] [PATCH 15/16] support replication driver in blockdev-add, Wen Congyang, 2015/09/02