Re: [Qemu-devel] [PATCH v2 3/6] block: Extract blockdev part of qmp_drive_mirror

[Max Reitz]

On 25.06.2015 05:22, Fam Zheng wrote:
> This is the part that will be reused by blockdev-mirror.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
>   blockdev.c | 155 ++++++++++++++++++++++++++++++++++++-------------------------
>   1 file changed, 92 insertions(+), 63 deletions(-)

As you probably know (since you introduced it), this needs fixup due to 
0fc9f8ea28.
(And the changes are not trivial, unfortunately, so I had to give up 
fixing it locally.)

Generally, the set of changes looks good to me, though.

Max