[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] net: fix insecure temporary file creation in SL
|
From: |
Michael Tokarev |
|
Subject: |
Re: [Qemu-devel] [PATCH] net: fix insecure temporary file creation in SLiRP |
|
Date: |
Mon, 01 Jun 2015 11:49:03 +0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 |
01.06.2015 11:47, Paolo Bonzini пишет:
>
>
> On 01/06/2015 09:58, Markus Armbruster wrote:
>>>> - snprintf(s->smb_dir, sizeof(s->smb_dir), "/tmp/qemu-smb.%ld-%d",
>>>> - (long)getpid(), instance++);
>>>> - if (mkdir(s->smb_dir, 0700) < 0) {
>>>> - error_report("could not create samba server dir '%s'",
>>>> s->smb_dir);
>>>> + if (!(tmpdir = mkdtemp(smb_dir))) {
>
> mkdtemp is unfortunately missing on Windows, and g_mkdtemp requires glib
> 2.30.
This code is within #ifndef WIN32 block.
/mjt